[lld][ELF] Simplify handleLibcall. NFC #78659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this while working on llvm#78658
|
@llvm/pr-subscribers-lld-elf @llvm/pr-subscribers-lld Author: Sam Clegg (sbc100) ChangesI noticed this while working on #78658 Full diff: https://github.com/llvm/llvm-project/pull/78659.diff 1 Files Affected:
diff --git a/lld/ELF/Driver.cpp b/lld/ELF/Driver.cpp
index 5ccc65600dcb91..07f4263c90e62b 100644
--- a/lld/ELF/Driver.cpp
+++ b/lld/ELF/Driver.cpp
@@ -2081,13 +2081,7 @@ static void handleUndefinedGlob(StringRef arg) {
static void handleLibcall(StringRef name) {
Symbol *sym = symtab.find(name);
- if (!sym || !sym->isLazy())
- return;
-
- MemoryBufferRef mb;
- mb = cast<LazyObject>(sym)->file->mb;
-
- if (isBitcode(mb))
+ if (sym && sym->isLazy() && isa<BitcodeFile>(sym->file))
sym->extract();
}
|
MaskRay
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks! I think this opportunity is enabled by my previous change removing LazyArchive https://reviews.llvm.org/D119074
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while working on #78658